-
-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deviantart problem: The image at $FOO does not exist #392
Comments
The CI build from yesterday finished without error, so this change happened at some point since then. DeviantArt seems to have finally replaced its old layout with the new one for everyone, and gallery-dl relied on it to map numerical IDs like Entire galleries like |
TODO: - journal downloads - test for all media types
While the latest commit (30d6e28) makes single deviations downloadable, You can still view the "proper" name by getting the entire gallery, but that's hardly ideal.
A solid way I've found to be able to get filenames again is to look at
|
- consistent 'filename' entries, at least as far as possible - GIFs and SWFs don't have a <title>_by_<artist>_<id> anywhere in their metadata - Generating <id> (from 'deviationid'?) might be something that needs to be figured out, so we can build those filenames ourselves - better code structure etc. - tests for videos, archives, and flash animations
Anyway, I implemented your suggestion and found that GIFs and SWF files don't have a "proper" filename anywhere in their metadata. All files now have both a |
Yeah I know it wasn't perfect, but hell deviantart is pretty far from perfect right now. Thanks for implementing it, at least it's better than having no filename. Also nitpicking but could you forcefully change the last _ to a - (like they used to be before all this mess), I have a script for this that I typically run but it'd be nice to have it built in. Edit: Saw the commit implementing that as well, you're an absolute saint <3 |
<title>_by_<user>_<id> --> <title>_by_<user>-<id>
Now it works without problems, thanks! 👍🏻 Edit: typo |
The original issue has been resolved and all DeviantArt media types now have a "proper" |
I updated the program a few minutes ago (from the GitHub source) and now I can't download any Deviantart post (I didn't use the program to download Deviantart material for a few days, though, so I can't be sure when it did break and why). Here's what the program says (-v flag used, of course):
The same goes for any Deviantart post and changing the user agent in the .conf file didn't help. Maybe an implementation of a log-in mechanism would help?
Edit: The download feature of JDownloader seems to be still working, so you maybe could look at the JDownloader source for “inspiration”?
The text was updated successfully, but these errors were encountered: