New feature: Added static parser: argument into quotes. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miko007
reviewed
Oct 19, 2022
SerialTerminal.hpp
Outdated
| @@ -183,6 +183,26 @@ namespace maschinendeck { | |||
|
|
|||
| return Pair<String, String>(keyword, message); | |||
| } | |||
|
|
|||
| static String ParseArgument(String message) { | |||
There was a problem hiding this comment.
do you really think, this is neccesary? the cli gets split on the first space, what is the need for the quotes?
There was a problem hiding this comment.
yes, for example for password user-case. Is working like a charm here:
https://github.com/hpsaturn/esp32-wifi-cli/
There was a problem hiding this comment.
i looked at your example, of course, but what exactly is the benefit from the quotation marks? you could to the exact same thing without them, couldnt you?
There was a problem hiding this comment.
I think that not, because is possible have passwords with spaces in the end. For example the next password: " xxx xxxx ". How you could handle it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WiFi Setup example features