[MIK-248] Build modal for novel builder #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miku448
reviewed
Jun 25, 2024
| @@ -71,11 +72,11 @@ export default function PreviewPanel() { | |||
| [] | |||
| ); | |||
|
|
|||
| const handleBuild = async () => { | |||
| const handlExport = async (exportFor: "miku" | "local") => { | |||
There was a problem hiding this comment.
"miku" export should actually call the same function as the button "save" but return the json with a different extension .miku-light.json instead of .miku-temp.json
miku448
reviewed
Jun 25, 2024
| <p>Select how you'd like to export your project:</p> | ||
| <ul className="PreviewPanel__options"> | ||
| <li className="PreviewPanel__option"> | ||
| <strong>Export for Miku.gg:</strong> |
There was a problem hiding this comment.
remove the :, is already distinctive enough.
Also, I recommend using a better style, remove the dots form list to too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.