Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor into workspaces: libcramjam, cramjam-python, and cramjam-cli #101

Merged
merged 21 commits into from
May 3, 2023

Conversation

milesgranger
Copy link
Owner

@milesgranger milesgranger commented May 1, 2023

(Holiday/weekend project)

  • Split into workspaces [libcramjam, cramjam-python, cramjam-cli]
  • New CLI distribution, first just in python, cramjam-cli exposting all the de/compress core implementations of each variant.

@milesgranger milesgranger changed the title [WIP] Refactor into workspaces: libcramjam, cramjam-python, and cramjam-cli Refactor into workspaces: libcramjam, cramjam-python, and cramjam-cli May 3, 2023
@milesgranger milesgranger marked this pull request as ready for review May 3, 2023 18:13
@milesgranger milesgranger merged commit c1b9478 into master May 3, 2023
@milesgranger milesgranger deleted the add-cli branch May 3, 2023 18:14
@martindurant
Copy link

How did you approach such a thorough rearrangement?

@milesgranger
Copy link
Owner Author

Started off trying to implement a CLI interface, became a bit unsatisfied w/ some side-effects of it being inside of Python's library implementation, and anyway had been thinking for a while to make a pure Rust crate, which ought to help with #97. Still a fair amount of shifting things about, like moving the block/frame stuff into libcramjam.

Otherwise, the jist was only to copy the previous cramjam into both libcramjam and cramjam-python then took out things that didn't belong; namely moving <<codec>>::internal::* into libcramjam, and removing from cramjam-python, replacing with libcramjam.

@milesgranger milesgranger mentioned this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants