Preserve unsupported media queries in head element #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add parameter to preserve unsupported media queries when removing sty…
|
Hey @sleeplessghost - thanks for submitting this. I can see how it is useful, any chance you'd add a unit test or two to safeguard this logic going forward? |
|
Sure, happy to do so |
|
@sleeplessghost Release to nuget https://www.nuget.org/packages/PreMailer.Net/2.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if using
removeStyleElementswhile also having media queries in<style>in<head>which cannot be inlined, these media queries will be lost.This adds a new parameter
preserveMediaQuerieswhich instead of removing the entire<style>node, will replace the inner styles with just the unsupported media queriesI realise you already have a a workaround for this of setting an id on the style node and using
ignoreElementsso feel free to close this if you would prefer to keep it as is