-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct usage of Timer and Ticker #22228
Conversation
@czs007 E2e jenkins job failed, comment |
@czs007 ut workflow job failed, comment |
others all looks good to me |
@czs007 ut workflow job failed, comment |
Signed-off-by: zhenshan.cao <[email protected]>
LGTM |
@czs007 ut workflow job failed, comment |
Codecov Report
@@ Coverage Diff @@
## master #22228 +/- ##
==========================================
+ Coverage 82.16% 82.36% +0.20%
==========================================
Files 705 704 -1
Lines 97513 95880 -1633
==========================================
- Hits 80120 78974 -1146
+ Misses 14430 13929 -501
- Partials 2963 2977 +14
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind improvement |
related : #22222