Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct usage of Timer and Ticker #22228

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Conversation

czs007
Copy link
Collaborator

@czs007 czs007 commented Feb 16, 2023

related : #22222

@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels Feb 16, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Feb 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2023

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2023

@czs007 ut workflow job failed, comment rerun ut can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

others all looks good to me

@mergify
Copy link
Contributor

mergify bot commented Feb 17, 2023

@czs007 ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor

LGTM

@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2023

@czs007 ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #22228 (47c77de) into master (7e19a92) will increase coverage by 0.20%.
The diff coverage is 89.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22228      +/-   ##
==========================================
+ Coverage   82.16%   82.36%   +0.20%     
==========================================
  Files         705      704       -1     
  Lines       97513    95880    -1633     
==========================================
- Hits        80120    78974    -1146     
+ Misses      14430    13929     -501     
- Partials     2963     2977      +14     
Impacted Files Coverage Δ
internal/datacoord/channel_manager.go 71.52% <0.00%> (-0.13%) ⬇️
internal/indexnode/taskinfo_ops.go 80.61% <83.33%> (-5.71%) ⬇️
internal/config/refresher.go 71.79% <100.00%> (-7.16%) ⬇️
internal/datacoord/channel_checker.go 97.52% <100.00%> (ø)
internal/datacoord/compaction.go 91.69% <100.00%> (ø)
internal/datacoord/garbage_collector.go 88.37% <100.00%> (+0.04%) ⬆️
internal/datanode/binlog_io.go 95.30% <100.00%> (ø)
internal/datanode/event_manager.go 81.60% <100.00%> (+0.21%) ⬆️
internal/proxy/proxy.go 66.31% <100.00%> (ø)
internal/querycoordv2/dist/dist_handler.go 75.14% <100.00%> (+0.14%) ⬆️
... and 186 more

@mergify mergify bot added the ci-passed label Feb 23, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@congqixia
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Feb 23, 2023
@sre-ci-robot sre-ci-robot merged commit e768437 into milvus-io:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants