Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] should not modify users search_param, copy instead #2578

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

PwzXxm
Copy link
Contributor

@PwzXxm PwzXxm commented Jan 16, 2025

issue: #2576
pr: #2577

Signed-off-by: Patrick Weizhi Xu [email protected]
(cherry picked from commit 5050421)

Signed-off-by: Patrick Weizhi Xu <[email protected]>
(cherry picked from commit 5050421)
@mergify mergify bot added the dco-passed label Jan 16, 2025
@PwzXxm PwzXxm changed the title fix: [2.5]should not modify users search_param, copy instead fix: [2.5] should not modify users search_param, copy instead Jan 16, 2025
@mergify mergify bot added the ci-passed label Jan 16, 2025
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PwzXxm, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit dc35ea2 into milvus-io:2.5 Jan 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants