we expect unspent outputs but play it safe (#517)

mimblewimble · Sep 14, 2020 · 8077d01 · 8077d01
1 parent 073c63a
commit 8077d01
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/impls/src/node_clients/http.rs b/impls/src/node_clients/http.rs
@@ -321,7 +321,8 @@ impl NodeClient for HTTPNodeClient {
 
 		let params = json!([start_index, end_index, max_outputs, Some(true)]);
 		let res = self.send_json_request::<OutputListing>("get_unspent_outputs", &params)?;
-		for out in res.outputs {
+		// We asked for unspent outputs via the api but defensively filter out spent outputs just in case.
+		for out in res.outputs.into_iter().filter(|out| out.spent == false) {
 			let is_coinbase = match out.output_type {
 				api::OutputType::Coinbase => true,
 				api::OutputType::Transaction => false,