-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix compile error #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mcdallas
commented
Feb 16, 2019
garyyu
approved these changes
Feb 16, 2019
confused since this built fine locally and passed travis tests and produced a build.. what version of rust are you using? |
I can confirm that I get this compilation error on Windows, adding |
ahhh... windows... |
I'm on Ubuntu using rust 1.31.1 stable |
garyyu
added a commit
that referenced
this pull request
Apr 25, 2019
* store receiver's output into the sender's database * rustfmt * payment output refresh * fix the test code in libwallet * rustfmt * fix wallet_command_line test * modify the warning message for self sending * a bit of unit test according to review comments * display unknown value for the case of multiple outputs on single receiver, normally it's not the case of this wallet implementation * rustfmt * fix merge missing parts * rustfmt * use PaymentCommitMapping struct instead of a tuple * rustfmt * fix the test * fix the owner api rpc test
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
* store receiver's output into the sender's database * rustfmt * payment output refresh * fix the test code in libwallet * rustfmt * fix wallet_command_line test * modify the warning message for self sending * a bit of unit test according to review comments * display unknown value for the case of multiple outputs on single receiver, normally it's not the case of this wallet implementation * rustfmt * fix merge missing parts * rustfmt * use PaymentCommitMapping struct instead of a tuple * rustfmt * fix the test * fix the owner api rpc test
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.