API Token Fixes #218
Merged
API Token Fixes #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i when run on same port as owner api
This was referenced Sep 13, 2019
yyangli
pushed a commit
to mwcproject/mwc-wallet
that referenced
this pull request
May 13, 2020
* split api secret into owner_api secret and node api secrets * update for master, drop requirement for authentication for foreign api when run on same port as owner api * rustfmt * re-trigger build
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
* split api secret into owner_api secret and node api secrets * update for master, drop requirement for authentication for foreign api when run on same port as owner api * rustfmt * re-trigger build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
option_to_not_foundfunction calls to latest form on grin masterAddresses all known outstanding Auth issues: #183, #203, #93
On release, users may have to re-organize their API tokens, this needs to be clearly stated in release notes along with instructions. Notes are:
.api_secretand.owner_api_secret.api_secretis the secret shared with the node for wallet to node communication. Previous versions used this file for both node communication and Owner API authentication. This file should now only be used for the node secret and users should update files and paths ingrin-wallet.tomlaccordingly.owner_api_secretis now used only to authenticate the Owner API.grin-wallet.toml,api_secret_pathcorresponds to the Owner API secret file (.owner_api_secretby default), whilenode_api_secret_pathcorresponds to the node secret file (.api_secretby default)owner_api_include_foreignoption ingrin-wallet.toml, calls to the Foreign API no longer require the Owner API authentication secret.