Version check fix + Rustfmt #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeastplume
added a commit
to yeastplume/grin-wallet
that referenced
this pull request
Jan 14, 2020
* Correct node version check * rustfmt * update pre-commit hook
yeastplume
added a commit
that referenced
this pull request
Jan 14, 2020
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
* Correct node version check * rustfmt * update pre-commit hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes node version check on startup to correctly look for a 3.0.0, which was overlooked prior to 3.0.0 release. Shouldn't be a huge problem in practice since everyone needs to update to 3.0.0 anyhow, but included for correctness.
Also updates the pre-commit hook to the version in grin, which rustfmts on commit instead of needed to perform a separate commit.
To be cherrypicked to master