Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serde(default) specifier to fields to send tx args #316

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

yeastplume
Copy link
Member

Fixes #310, turns out the custom specifiers were stripping the fields of all the serde-derived behaviour, so a the default specifier needs to be specifically included.

Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yeastplume yeastplume merged commit 14e126b into mimblewimble:master Jan 29, 2020
@yeastplume yeastplume deleted the default_val_fix branch March 3, 2020 08:37
antiochp pushed a commit to antiochp/grin-wallet that referenced this pull request Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: Some optional arguments in init_send_tx are not optional
2 participants