Final Owner API Changes #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyyu
added a commit
to garyyu/grin-wallet
that referenced
this pull request
Jul 22, 2019
* Clearer user messaging when node in use is 1.1.0 or less (mimblewimble#168) * Modify error message when checking against old nodes to reflect 1.x.x series * update output text * Bump version number to official v2.0.0 release
yyangli
referenced
this pull request
in mwcproject/mwc-wallet
May 13, 2020
* node height return value and documentation * rustfmt * add parameter struct for initiate tx functions * rustfmt * change tx estimate to use InitTxArgs * rustfmt * transaction estimate * rustfmt * initiate tx args fixed * add send args to init * rustfmt * last owner api documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final round of changes and documentation for the V2 Owner API, most notably:
initiate_txinto a separate structestimate_initiate_txand roll functionality into the maininitiate_txfunction via a parameterinitiate_txinstructing API to exchange, finalize and post transactions in one go, to emulate thesend_txfunctionality in V1