Convert node client to use V2 Node API #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -165,7 +165,7 @@ impl Client { | |||
| /// provided JSON object as body on a given URL that returns a future. Handles | |||
| /// request building, JSON serialization and deserialization, and response code | |||
| /// checking. | |||
| pub fn _post_async<IN, OUT>( | |||
| pub fn post_async<IN, OUT>( | |||
There was a problem hiding this comment.
Out of curiosity why not using pub async fn?
There was a problem hiding this comment.
This code is originally from the grin repo.
My PR there is updating the code to use pub async fn, although iirc the wallet only uses the blocking function. Using the blocking functions many times is not really optimal since it spawns a full runtime for each request, but its something we can improve in a separate PR. For this PR i think its fine to leave as is
There was a problem hiding this comment.
Indeed, focus is elsewhere on this PR, can likely make improvements later.
yeastplume
changed the title
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
* add beginnings of jsonrpc node client, get_chain_tip implementation * version info and outputs from node * return async split up of get_output requests * add and test get kernel functionality * height range to pmmr indices * test fixes * outputs by pmmr index
This was referenced Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, includes new JSON-RPC client library code.
Will address #305