Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact Slate - Compact Version Field #377

Closed
wants to merge 30 commits into from
Closed

Compact Slate - Compact Version Field #377

wants to merge 30 commits into from

Conversation

yeastplume
Copy link
Member

@yeastplume yeastplume commented Apr 15, 2020 •
edited
Loading

Requires #366, may rebuild this PR to clean up the commit history once parent is merged

  • Removes unnecessary de/ser directives from internal Slate object
  • Serializes version_info field as ver in "[version].[block_header_version]" format
  • Removes SlateVersionProbe (slate can be upgraded to latest by deserializing an enum
  • Update doctests

yeastplume added 30 commits March 13, 2020 13:03
@yeastplume
WIP add support for sending compact slates
cdedef1
@yeastplume
add repopulate_tx function to internal API
98603a9
@yeastplume
first pass at compacted slate working
2ebae92
@yeastplume
move slate compaction to separate function
d9784cf
@yeastplume
test fixes
c00266a
@yeastplume
support compact slate inits in invoice workflow
7b173df
@yeastplume
add compress flags to send and invoice
f6da7b0
@yeastplume
attempting to remove is_compact and assume all V4 slates begin as com…
1d6a536 
…pact
@yeastplume
attempting to calculate offsets when full tx data isn't available
4a45c7d
@yeastplume
update calc_commit to use participant blind data
11d7872
@yeastplume
update doctests for compact slates
ea551ea
@yeastplume
start to remove unneeded fields from serialization
8c80ffd
@yeastplume
make num_participants optional
47e3c03
@yeastplume
remove other_version from slate
56c022c
@yeastplume
Merge branch 'master' into compact_slate_send
2ea52fc
@yeastplume
use grin master branch
b3a60b3
@yeastplume
remove message field
562067a
@yeastplume
lock height assumed to be 0 if it doesn't exist
386de9a
@yeastplume
don't serialise receiver signature when null
b025ec5
@yeastplume
don't serialize payment_info if not needed
c2bcab8
@yeastplume
remove participant id from participant info
d35362c
@yeastplume
add note on id field
6305eb5
@yeastplume
fix finalize and receive doctests
e0a6870
@yeastplume
finalize_tx tests, init_send_tx tests
ee2c9a8
@yeastplume
doctests for process_invoice_tx, retrieve_tx, tx_lock_outputs
8ba5023
@yeastplume
finished test changes
c85a6ca
@yeastplume
change serialization of version info, remove unneeded traits from ver…
ee6df2f 
…sioned slates
@yeastplume
text fixes and retain internal version_info name
091be5f
@yeastplume
rest of doctest fixes
5365ce0
@yeastplume
remove SlateVersionProbe and replace with enum deserialization
94aac52
@yeastplume yeastplume mentioned this pull request Apr 15, 2020
Closed
@yeastplume yeastplume changed the base branch from master to 4.0.0/compact_slates April 17, 2020 10:23
@yeastplume
Copy link
Member Author

Closed in favor of #380 on the 4.0.0/compact_slate branch

@yeastplume yeastplume closed this Apr 17, 2020
@yeastplume yeastplume deleted the compact_slate_2 branch April 17, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yeastplume