Post Hardfork 3 Cleanup #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…slate, remove is_compact, derive slate state based on slate state field
|
Think this all seems to be okay now. Would appreciate if someone else could give it a quick sanity check before merging! |
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
* Change versioning on master to 4.1.x development * Remove SlateV3, V3 References from command-line code * continue to remove pre HF3 functionality, remove participant_id from slate, remove is_compact, derive slate state based on slate state field * slate no longer needs explicit compact step * version/build coinbase doctest cleanup * don't attempt to store transaction during tx lock if it doesn't exist * repair incorrectly removed logic * last test fixes (hopefully)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective is to carefully remove the considerable amount of code and logic in places that was needed to support communication with V3.0.0 wallets pre-hardfork. Thus far (will update as we go):
Will likely not be merging this into the 4.0.x maintenance branch (will leave well-enough alone there, as these removals will need to be tested over time)