handle transaction inputs correctly #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
antiochp
force-pushed
the
inputs_commit_only
branch
2 times, most recently
from
37bdac1 to
7342e07
Compare
antiochp
force-pushed
the
inputs_commit_only
branch
from
7342e07 to
db19965
Compare
|
mimblewimble/grin#3419 is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge prior to mimblewimble/grin#3419- DONERelated mimblewimble/grin#3419
The node PR above defaults transactions to protocol version v3 which use "commit only" inputs, omitting the input features.
This PR updates how we create default empty transactions to ensure we continue to use "features and commit" inputs correctly.
Grin wallet serializes/deserializes transactions to the db in v1 format and we need to ensure we handle inputs correctly.