-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azure to use latest, fix warnings #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to reintroduce the rustup install thing otherwise this won't be tested against beta and nigthly.
Since macOS and Linux:
and Windows:
|
It looks like Rustup is not included in Windows Server 2019 (https://github.com/actions/virtual-environments/blob/master/images/win/Windows2019-Readme.md). You might want to try the above. Otherwise you need to add:
|
Unfortunately on windows that brings us right back to the original issue: |
@yeastplume can you try this on Windows:
and remove this line:
|
Wondering if this is necessary to export again the Cargo path on Windows ( |
Found the reason rust-lang/rustup#2203 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving my own fix 👍
* update azure to use latest, fix warnings * add toolchain commands * Fix Win CI * Go back to previous command * The Fix Co-authored-by: Quentin Le Sceller <[email protected]>
* Update CI (mimblewimble#65) * attempt to fix windows build * remove all explicit rust installation steps * update mac os image * Implement PartialOrd and Ord (mimblewimble#62) * Implement PartialOrd and Ord * Fix spaces * Add create commit from pubkey function (mimblewimble#64) * Update azure to use latest, fix warnings (mimblewimble#66) * update azure to use latest, fix warnings * add toolchain commands * Fix Win CI * Go back to previous command * The Fix Co-authored-by: Quentin Le Sceller <[email protected]> * version bump for release (mimblewimble#67) * fix from_pubkey function * Revert "fix from_pubkey function" This reverts commit a5f08e3. * Update Grin Website * Commit to pubkey fix (mimblewimble#68) * commit_to_pubkey fix * version bump for next release * retrigger build * Fix compiler warning (mimblewimble#70) * Fuzz tests for various components * Fix error formatting (mimblewimble#75) * Update version to v0.7.10 * Update zeroize dependency (mimblewimble#78) * Bump version to v0.7.11 (mimblewimble#79) * update dependency seck256k1 branch to latest master with aggsig subtraction function * Aggsig signature subtraction function, rust side (mimblewimble#81) * addition of ffi+api functions for aggsig partial sig subtract * updated aggsig lib function to return more results based on underlying function * update submodule to latest master * clean up test result check * bump version number * update depend/secp256k1-zkp * update version --------- Co-authored-by: Yeastplume <[email protected]> Co-authored-by: jaspervdm <[email protected]> Co-authored-by: Quentin Le Sceller <[email protected]> Co-authored-by: Nym Seddon <[email protected]> Co-authored-by: GeneFerneau <[email protected]>
Further update to CI settings and fix for warnings:
ubuntu-latest
,windows-latest
andmacos-latest
imagesdyn
warningmem::uninitialized()
tomem::MaybeUninit::uninit().assume_init()