Strange issue on with 3.0, background jobs, Heroku and HTML email attachments #117
Assignees
Comments
|
I need more information than I have. At a minimum, I need a bigger backtrace, but that won’t probably be enough. Ideally, you can create a sample project that does this on a Heroku hobby project where we can add some deeper logging to figure out what’s going on. I remember seeing something that suggests Heroku hobby projects can have one hobby worker, and you can configure the mailer bits to send to a mail trap so that you’re not even sending accidental spam through this worker. |
|
Sure. It will take me little time to create a sample project, but in the meantime, here is a bigger portion of the backtrace: |
|
Thanks. I have also commented on the SO thread indicating that downgrading isn’t the right answer and asking that poster for more information on this bug. I think that this is an Other bug (I say upstream in my comment, but I guess it’s actually downstream from mime-types…), because I didn’t change any of that code, but I can’t figure out why downgrading to 2.x would make a difference. |
|
Hi. Are you able to share your |
halostatue
added a commit
that referenced
this issue
May 22, 2016
* 3 bug fixes
* A test for MIME::Types::Cache fails under Ruby 2.3 because of frozen
strings #118. This has been fixed.
* The JSON data has been incorrectly encoded since the release of
mime-types 3 on the +xrefs+ field, because of the switch to using a Set
to store cross-reference information. This has been fixed.
* A tentative fix for #117 has been applied, removing the only circular
require dependencies that exist (and for which there was code to
prevent, but the current fix is simpler). I have no way to verify this
fix and depending on how things are loaded by `delayed_job`, this fix
may not be sufficient.
* 1 governance change
* Updated to Contributor Covenant 1.4.
Merged
halostatue
added a commit
that referenced
this issue
May 22, 2016
* 3 bug fixes
* A test for MIME::Types::Cache fails under Ruby 2.3 because of frozen
strings #118. This has been fixed.
* The JSON data has been incorrectly encoded since the release of
mime-types 3 on the +xrefs+ field, because of the switch to using a Set
to store cross-reference information. This has been fixed.
* A tentative fix for #117 has been applied, removing the only circular
require dependencies that exist (and for which there was code to
prevent, but the current fix is simpler). I have no way to verify this
fix and depending on how things are loaded by `delayed_job`, this fix
may not be sufficient.
* 1 governance change
* Updated to Contributor Covenant 1.4.
halostatue
added a commit
that referenced
this issue
May 22, 2016
* 3 bug fixes
* A test for MIME::Types::Cache fails under Ruby 2.3 because of frozen
strings #118. This has been fixed.
* The JSON data has been incorrectly encoded since the release of
mime-types 3 on the +xrefs+ field, because of the switch to using a Set
to store cross-reference information. This has been fixed.
* A tentative fix for #117 has been applied, removing the only circular
require dependencies that exist (and for which there was code to
prevent, but the current fix is simpler). I have no way to verify this
fix and depending on how things are loaded by `delayed_job`, this fix
may not be sufficient.
* 1 governance change
* Updated to Contributor Covenant 1.4.
|
Hi, @samstickland. At your earliest convenience, can you try this again with mime-types 3.1? The only thing I can guess is that somehow mime-types was partially loading for your background jobs, but somehow not getting through I have changed how all this loads so that there’s no guard clauses for circular requires now, just smarter loading in general. |
|
Hi, I've just tried this with 3.1 and emails are now sent correctly from the background job! Thanks for your help :) |
|
Glad that this worked out. I have put a comment on the SO issue as well. |
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this issue
Oct 15, 2016
== 3.1 / 2016-05-22 * 1 documentation change: * Tim Smith (@tas50) updated the build badges to be SVGs to improve readability on high-density (retina) screens with pull request {#112}[mime-types/ruby-mime-types#112]. * 3 bug fixes * A test for MIME::Types::Cache fails under Ruby 2.3 because of frozen strings, {#118}[mime-types/ruby-mime-types#118]. This has been fixed. * The JSON data has been incorrectly encoded since the release of mime-types 3 on the +xrefs+ field, because of the switch to using a Set to store cross-reference information. This has been fixed. * A tentative fix for {#117}[mime-types/ruby-mime-types#117] has been applied, removing the only circular require dependencies that exist (and for which there was code to prevent, but the current fix is simpler). I have no way to verify this fix and depending on how things are loaded by +delayed_job+, this fix may not be sufficient. * 1 governance change * Updated to {Contributor Covenant 1.4}[Code-of-Conduct_rdoc.html].
This was referenced Aug 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
After mime-types upgraded to 3.0 and brought mime-types-data 3.2016.0221 along with it I started getting errors from my Heroku background jobs (via delayed-job) when they try to send an email.
This was fired when we try to attach an HTML attachment via:
I could not reproduce this locally, either via
deliver_nowordeliver_later+rake jobs:workoffHowever locking mime-types to '<3' has 'fixed' the issue.
I'm not sure where to start investigating this, since I am having trouble reproducing anywhere except production (which is not the ideal test environment ;)
The same error message has been reported by someone else here: http://stackoverflow.com/questions/36709845/cannot-add-inline-attachment-with-actionmailer-in-rails-3 Although the circumstances are possibly a little different.
The text was updated successfully, but these errors were encountered: