Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a section link in README.rdoc [ci skip] #105

Merged
merged 2 commits into from
Sep 14, 2015
Merged

Fix a section link in README.rdoc [ci skip] #105

merged 2 commits into from
Sep 14, 2015

Conversation

JuanitoFatas
Copy link
Contributor

This pull request fix the link to columnar store section.

Before

screenshot 2015-05-27 09 39 35

After

screenshot 2015-05-27 09 39 57

View Rendered README.rdoc

@halostatue
Copy link
Member

There is a bug in the document, but this is not the correct fix. I write the README in rdoc for rdoc; the link should be #label-Columnar+Store, not just #columnar-store. When viewing the rendered rdoc, that will result in the correct behaviour.

halostatue added a commit that referenced this pull request Sep 14, 2015
Fix a section link in README.rdoc [ci skip]
@halostatue halostatue merged commit 074e9b5 into mime-types:master Sep 14, 2015
@JuanitoFatas JuanitoFatas deleted the doc/readme branch September 14, 2015 09:37
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Oct 4, 2015
== 2.6.2 / 2015-09-13

* Bugs:
  * Emilio Losada (@losadaem) fixed an error where +each_with_object+'s block
    parameters are the inverse of those used by +inject+. Resolves
    {#107}[mime-types/ruby-mime-types#107] with pull
    request {#108}[mime-types/ruby-mime-types#108].
  * Matt Beedle (@mattbeedle) fixed a typo in MIME::Type::Columnar negatively
    affecting people who use the +use_instead+ functionality. Resolved in
    {#109}[mime-types/ruby-mime-types#109].
* Documentation:
  * Juanito Fatas (@JuanitoFatas) fixed a documentation issue with the README
    not properly linking internally on the generated rdoc source. Resolved with
    {#105}[mime-types/ruby-mime-types#105].
* Development:
  * Fixed a minor issue in the IANA registry parser that would generate empty
    +text+ xrefs if the +text+ section was empty.
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Nov 6, 2015
== 2.6.2 / 2015-09-13

* Bugs:
  * Emilio Losada (@losadaem) fixed an error where +each_with_object+'s block
    parameters are the inverse of those used by +inject+. Resolves
    {#107}[mime-types/ruby-mime-types#107] with pull
    request {#108}[mime-types/ruby-mime-types#108].
  * Matt Beedle (@mattbeedle) fixed a typo in MIME::Type::Columnar negatively
    affecting people who use the +use_instead+ functionality. Resolved in
    {#109}[mime-types/ruby-mime-types#109].
* Documentation:
  * Juanito Fatas (@JuanitoFatas) fixed a documentation issue with the README
    not properly linking internally on the generated rdoc source. Resolved with
    {#105}[mime-types/ruby-mime-types#105].
* Development:
  * Fixed a minor issue in the IANA registry parser that would generate empty
    +text+ xrefs if the +text+ section was empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants