Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "force ssh fingerprints adding to known_hosts" #356

Closed
moll opened this issue Dec 11, 2015 · 1 comment
Closed

Revert "force ssh fingerprints adding to known_hosts" #356

moll opened this issue Dec 11, 2015 · 1 comment

Comments

@moll
Copy link

moll commented Dec 11, 2015

07cd940

I don't know how often this code gets used, but disabling security checks if an offense punishable by 1300 pushups and heaps of shame!
@Mythra Mythra mentioned this issue Dec 29, 2015
Closed
aleksanb pushed a commit to Samfundet/mina that referenced this issue Feb 18, 2016
@aleksanb
Unforce SSH fingerprints adding to known hosts
d8449b7 
fixes mina-deploy#356

removes the option in ssh_helpers being added to known hosts.
this is unnecessary, and causes a security hole for those wanting
to use this library without the need to disable StrictHostKeyChecking
if you want to use this you can use your own ssh_config
@d4be4st
Copy link
Member

d4be4st commented Jul 8, 2016

Fixed in new 1.0.0 version

@d4be4st d4be4st closed this as completed Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unforce SSH fingerprints adding to known hosts
2 participants
@moll @d4be4st