Help wanted: Windows mingw32 shell (git bash) - CRLF

[ghost]

First things first - thanks for great tool 👍

I am using Windows now (yeah...) and trying to deploy with Mina.

I found that generated bash script on Windows Git Bash (mingw32 standard shell) has CRLF line endings, but linux use LF, so there are errors like "Unexpected EOF".

I write this generated script to file, convert line endings to LF and use it manually - everything works fine.

Is this a Mina feature or a mingw32 bug or misconfiguration? :)

[rstacruz]

Hm. Are you trying to deploy to a Windows server, or a running on a Windows workstation?

Thanks for the heads up—unfortunately we don't have a Windows machine right now to test but I suppose we can work on some hypothetical fixes.

[rezen]

I'm having the same issue. On Win7x64 trying to deploy to CentOS

 bash: -c line 106: unexpected EOF while looking for a matching `"'

[mcavallo]

One of my co-workers have this problem as well when deploying to a Ubuntu server. He's on Vista (no comments) with Git Bash (mingw32) and we are using Mina 0.3.0.

[marvinroger]

I got the same error as @rezen on Windows 8.1 x64 trying to deploy to Ubuntu LTS 12.04.3 x64.

[insub]

@reterius i have same error in windows.
How rite this generated script to file, convert line endings to LF and use it manually ?

[insub]

Now I know why.
Shellwords.escape method for Ruby doesn't support windows environment.
So, in order to fix it, I added a little bit of code to the lib/mina.rb.
It works!

I'm a newbie, so.... but anyway，it works.

# lib/mina.rb
module Mina
  #if windows os
  require 'rbconfig'
  is_windows = (RbConfig::CONFIG['host_os'] =~ /mswin|mingw|cygwin/) 
  if is_windows
    module Shellwords
      def shellescape(str)
          '"' + str.gsub(/\\(?=\\*\")/, "\\\\\\").gsub(/\"/, "\\\"").gsub(/\\$/, "\\\\\\").gsub("%", "%%") + '"'
      end

      module_function :shellescape
      class << self
        alias escape shellescape
      end
    end
  end
...

[wfschmitt]

works great !! not newbie .... expert

[rezen]

Did this tweak make it into the codebase?

[kim3er]

Would it help progress this issue, if I put @insub's fix into a pull request?

[dynasource]

@coredevelopers: any reason why this isnt picked up? Solution by insub works. Why not do minor patches to support the windows community?

[dima-stefantsov]

It works indeed. Thanks!

[d4be4st]

Can someome test github master if this works?