Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy command for assets #150

Merged
merged 1 commit into from
May 13, 2014
Merged

Fix copy command for assets #150

merged 1 commit into from
May 13, 2014

Conversation

joshdover
Copy link
Contributor

The previous cp command resulted in an extra 'assets' directory in the build_path:

build_path
 |- public/
     |- assets/
         |- assets/

The previous cp command resulted in an extra 'assets' directory in the build_path:

build_path
 |- public/
     |- assets/
         |- assets/
@reisub
Copy link

reisub commented Mar 24, 2014

@nadarei
Please merge this pull request, I just ran into this issue.

@gabskoro
Copy link
Member

gabskoro commented May 3, 2014

Hi @Gerfuls and @reisub, this command will not create and extra assets folder until the assest folder already exits in the public folder, which is not the case here.

@asanghi
Copy link

asanghi commented May 4, 2014

I also see this behaviour.
@gabskoro assets folder already exists though.

gabskoro added a commit that referenced this pull request May 13, 2014
@gabskoro gabskoro merged commit 3b7f7d2 into mina-deploy:master May 13, 2014
gabskoro added a commit that referenced this pull request May 13, 2014
@joshdover joshdover deleted the fix-asset-copy branch May 13, 2014 22:49
@joshdover
Copy link
Contributor Author

@gabskoro Is there a reason this got reversed in c171bc1?

@gabskoro
Copy link
Member

@Gerfuls I just added quotes, looks cleaner for me, nothing else :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants