Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bundle_bin option #6

Merged
merged 1 commit into from
Jun 11, 2012
Merged

Conversation

Arcath
Copy link
Contributor

@Arcath Arcath commented Jun 11, 2012

I had an issue with mina where it wasn't picking up on the path for my gems so my deployments where failing on the bundle command.

This change just adds a bundle_bin option to allow you too set a custom path to the bundle binary. In my deploy.rb I use:

set :bundle_bin, '/var/lib/gems/1.8/bin/bundle'

which solves my problem.

Other than this mina working great :D thanks for writing this awesome tool!

@Arcath
Copy link
Contributor Author

Arcath commented Jun 11, 2012

Mina wasn't seeing my bundler command so kept failing to deploy.

Not a massive change which to 99% of people wont make difference but its just useful to be able to alter the path if for what ever reason your path changes dont apply or you want to use a specific bundler installation

@rstacruz
Copy link
Member

Thanks!

Another option is to add export PATH=/var/lib/gems/1.8/bin:$PATH to your .bashrc, since .bashrc is now read @ v0.1.2.pre1.

rstacruz added a commit that referenced this pull request Jun 11, 2012
@rstacruz rstacruz merged commit b6d0b75 into mina-deploy:master Jun 11, 2012
@Arcath
Copy link
Contributor Author

Arcath commented Jun 11, 2012

I do have that already in my .zshrc but it didn't seem to help.

@rstacruz
Copy link
Member

Mina always uses bash.

Also, the bashrc feature isn't available on the main release yet (it's a pre-release) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants