-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[models] ViT add checkpoints and some rework to use pretrained ViT backbone in ViTSTR #1072
[models] ViT add checkpoints and some rework to use pretrained ViT backbone in ViTSTR #1072
Conversation
@frgfm but the good on is i have learned a lesson in this PR. If we build TF models each layer should have a name otherwise we are lost in space if we iter trough the weights to find the problem 😅 |
Codecov Report
@@ Coverage Diff @@
## main #1072 +/- ##
==========================================
- Coverage 95.26% 95.21% -0.06%
==========================================
Files 145 142 -3
Lines 6046 6018 -28
==========================================
- Hits 5760 5730 -30
- Misses 286 288 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Felix!
Perhaps we should specify the change in perf in the documentation or somewhere? It's gonna become hard to track those changes otherwise
Yep will add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! 🚀
This PR:
All added checkpoints >98% acc
Any feedback is welcome