-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] replaces flake8 with ruff #1179
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1179 +/- ##
==========================================
- Coverage 95.01% 94.99% -0.02%
==========================================
Files 149 149
Lines 6417 6417
==========================================
- Hits 6097 6096 -1
- Misses 320 321 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @felixT2K 🙏
Two high-level comments:
- loving the suggestion to switch to ruff, I fully agree with that. I only added a few comments to make sure we have no regression from flake8 previous config
- for the rest, everything is on point, but let's make one objective per PR and focus that one on ruff if that's ok 😃
b0cd744
to
0fa65cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the migration Felix 👍
(I just noticed @felixdittrich92 & @felixT2K are the same haha)
"flake8>=3.9.0", | ||
"ruff>=0.0.260", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of security, I would have added an upper bound as well 0.1.0 for instance to avoid troubles with the CI later but nothing major 👍
Yeah it's my work profile 😅 |
This PR:
Benefits: