Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml - Fix rapidfuzz version #1298

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

khalidMindee
Copy link
Contributor

Fix rapidfuzz version raising error when installing doctr .

ModuleNotFoundError: No module named 'rapidfuzz.string_metric'

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlesmindee charlesmindee merged commit 7cd7e69 into main Aug 31, 2023
@charlesmindee charlesmindee deleted the khalidMindee-patch-1 branch August 31, 2023 14:20
@khalidMindee khalidMindee linked an issue Aug 31, 2023 that may be closed by this pull request
@github-actions
Copy link

Hey @charlesmindee 👋
You merged this PR, but it is not correctly labeled. The list of valid labels is available at https://github.com/mindee/doctr/blob/main/.github/verify_pr_labels.py

@felixdittrich92
Copy link
Contributor

Hi @khalidMindee @charlesmindee 👋 ,

I'm not sure how it's possible that the CI passes.
(Maybe cached)
Because the rapidfuzz code in doctr is already updated for >=3.0.0 we left the issue open to close it with the next release 😅

@felixT2K
Copy link
Contributor

felixT2K commented Sep 1, 2023

See: #1177
So could you revert your change please and reopen the issue ? I suggest to close it after the next release :)

@odulcy-mindee
Copy link
Collaborator

Thanks @felixdittrich92 for the catch. I'll revert this modification on main.
Also, we'll do minor release on an old commit with this fix.

@khanfarhan10
Copy link
Contributor

Any update on this, yet?

@charlesmindee @odulcy-mindee

@felixdittrich92
Copy link
Contributor

felixdittrich92 commented Mar 18, 2024

Any update on this, yet?

@charlesmindee @odulcy-mindee

? This is already fixed :)

"rapidfuzz>=3.0.0,<4.0.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency changed - remove rapidfuzz.string_metric module
6 participants