feat: ✨ use tqdm instead of fastprogress in reference scripts
#1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
==========================================
- Coverage 95.77% 95.75% -0.02%
==========================================
Files 155 155
Lines 6951 6951
==========================================
- Hits 6657 6656 -1
- Misses 294 295 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
felixdittrich92
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Thanks @odulcy-mindee lgtm :)
Only one thing if we are onces on it could you extend the progress bar also to each evaluation loop ?
felixdittrich92
added
type: bug
felixT2K
reviewed
Nov 23, 2023
felixT2K
reviewed
Nov 23, 2023
felixdittrich92
approved these changes
Nov 23, 2023
odulcy-mindee
changed the title
tqdm instead of fastprogresstqdm instead of fastprogress in reference scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not been able to run
train_pytorch.pyscript on Colab. An idea is to usetqdminstead offastprogress.Related to #1388 and #1106