-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prototype] Extend detection result customization #1449
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
==========================================
+ Coverage 95.81% 95.83% +0.02%
==========================================
Files 162 162
Lines 7101 7112 +11
==========================================
+ Hits 6804 6816 +12
+ Misses 297 296 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
demo/app.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to do the same on HF Space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep this would be good afterwards :)
@odulcy-mindee I added two points in the docs - as an advanced functionality for manipulation - i think it's better to mention it in the docs instead of producing some overhead to check after each hook that the coords are still relative in the range between 0 and 1 😅 |
@dchaplinsky What do you think from a user perspective ? Is it clear enough from the docs that input/output structure needs to be the same and the coords are relative so it needs also to be returned as relative (0-1) or should we add a check for the value range and shape (which would produce a small overhead) |
@felixdittrich92 I'm fine with it ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixdittrich92 Thnak you Felix, nice to have these hooks !
@felixdittrich92 well documented interface is enough. And the output format is dictated by the input format, so it will be strange if someone will receive relative coordinates and return absolute instead. |
Oh believe me i saw a lot 😂 |
This PR:
box_thresh
also accessible for end users (same asbin_thresh
)Any feedback is welcome