-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[transforms] small random resize improvement #1584
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
==========================================
- Coverage 96.35% 96.23% -0.12%
==========================================
Files 163 163
Lines 7701 7706 +5
==========================================
- Hits 7420 7416 -4
- Misses 281 290 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit curious to have only one parameter to control two behaviors. I mean, why not a parameter for preserve_aspect_ratio
and symmetric_pad
which can be a Union[bool, float]
, with float
as a parameter to control the probability to set this param ?
Yeah that's a good idea 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitively better, thank you !
Yeah this was a good catch 👍 |
This PR: