[Fix] close PIL images when loading images to tensor/numpy #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helpmefindaname
changed the title
helpmefindaname
changed the title
|
Hi @helpmefindaname 👋, Tanks for the fix good catch 👍 |
felixdittrich92
added
type: bug
|
failing build / script jobs are expected atm so don't wonder 😅 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1598 +/- ##
==========================================
+ Coverage 96.28% 96.30% +0.01%
==========================================
Files 163 163
Lines 7706 7707 +1
==========================================
+ Hits 7420 7422 +2
+ Misses 286 285 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
felixdittrich92
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior opened PIL images, but didn't release their memory, causing a huge memory leak on our training pipeline.
With this PR, the PIL images will be closed immediately after the copy as numpy array or torch tensor is created.