Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[builder] Add objectness scores #1625

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • unify detection predictor output (N, 5) / (N, 5, 2) --> last is objectness_score
  • add objectness score to Document output
  • update API template
  • update docs
  • add corresponding tests

Use case: enables the end user to filter out some detected artefacts for example

Any feedback is welcome 🤗

NOTE: API tests will fail until merged :)

Related to: #1612

@felixdittrich92 felixdittrich92 added topic: documentation Improvements or additions to documentation type: enhancement Improvement module: models Related to doctr.models module: utils Related to doctr.utils ext: tests Related to tests folder ext: api Related to api folder topic: text detection Related to the task of text detection ext: docs Related to docs folder labels May 31, 2024
@felixdittrich92 felixdittrich92 added this to the 0.9.0 milestone May 31, 2024
@felixdittrich92 felixdittrich92 self-assigned this May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (5eda559) to head (52a6850).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1625   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files         164      164           
  Lines        7716     7744   +28     
=======================================
+ Hits         7438     7465   +27     
- Misses        278      279    +1     
Flag Coverage Δ
unittests 96.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 marked this pull request as ready for review May 31, 2024 11:10
@felixdittrich92
Copy link
Contributor Author

ref.: #1612

@felixdittrich92 felixdittrich92 merged commit b9c4e6d into mindee:main Jun 7, 2024
80 of 81 checks passed
@felixdittrich92 felixdittrich92 deleted the box-scores branch June 7, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: api Related to api folder ext: docs Related to docs folder ext: tests Related to tests folder module: models Related to doctr.models module: utils Related to doctr.utils topic: documentation Improvements or additions to documentation topic: text detection Related to the task of text detection type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants