-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Specified imports of file_utils in __init__.py #447
Conversation
Hi @zalakbhalani 👋 Thanks for the PR! As you can see, without any modification of the codebase, the following snippet does work: from doctr import is_tf_available, is_torch_available If you manage to run the snippet, I'm not sure this PR is a "fix" as stated in the title 😅 If not, could you open an issue showing the error that you got? |
Oh ok. Thanks for the update. I faced this issue when I used doctr v0.2.1. I forgot to upgrade to newer versions. It is not a fix but can you approve the PR for the readability because at doctr/models/backbones/mobilenet/init.py you used |
Codecov Report
@@ Coverage Diff @@
## main #447 +/- ##
==========================================
+ Coverage 95.84% 95.87% +0.02%
==========================================
Files 96 96
Lines 3997 3997
==========================================
+ Hits 3831 3832 +1
+ Misses 166 165 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Thank you |
Fixed error while importing functions like
is_tf_available
andis_torch_available
because it is infile_utils.py
file.