Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: evaluate scripts and OCRDataset #474

Merged
merged 22 commits into from
Sep 17, 2021
Merged

refactor: evaluate scripts and OCRDataset #474

merged 22 commits into from
Sep 17, 2021

Conversation

charlesmindee
Copy link
Collaborator

This PR changes the evaluation script so it can be run with rotated boxes annotations, and the OCRDataset object has been changed to work with all test sets.

DocDataset has been removed, and all private test sets have been cleaned up and refactored to work with and OCRDataset object and the evaluation script.

Any feedback is welcome!

@charlesmindee charlesmindee self-assigned this Sep 15, 2021
@charlesmindee charlesmindee added module: datasets Related to doctr.datasets ext: scripts Related to scripts folder labels Sep 15, 2021
@charlesmindee charlesmindee added this to the 0.4.0 milestone Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #474 (4b67c70) into main (342239a) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
+ Coverage   95.36%   95.43%   +0.07%     
==========================================
  Files          96       97       +1     
  Lines        4053     4035      -18     
==========================================
- Hits         3865     3851      -14     
+ Misses        188      184       -4     
Flag Coverage Δ
unittests 95.43% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/ocr.py 88.00% <100.00%> (-1.10%) ⬇️
doctr/utils/visualization.py 93.57% <0.00%> (-0.06%) ⬇️
doctr/transforms/modules/base.py 91.22% <0.00%> (ø)
doctr/utils/fonts.py 92.85% <0.00%> (ø)
doctr/io/elements.py 90.44% <0.00%> (+0.28%) ⬆️
...dels/detection/differentiable_binarization/base.py 91.97% <0.00%> (+0.61%) ⬆️
doctr/datasets/classification/base.py 93.93% <0.00%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fec8be...4b67c70. Read the comment docs.

@fg-mindee fg-mindee changed the title refacto: evaluate scripts and OCRDataset refactor: evaluate scripts and OCRDataset Sep 16, 2021
@fg-mindee fg-mindee self-requested a review September 16, 2021 09:24
@fg-mindee fg-mindee added the type: breaking change Introducing a breaking change label Sep 16, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charlesmindee charlesmindee merged commit a3f70e6 into main Sep 17, 2021
@charlesmindee charlesmindee deleted the evaluate branch September 17, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: scripts Related to scripts folder module: datasets Related to doctr.datasets type: breaking change Introducing a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants