Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added unittest for PyTorch high-level zoo #499

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • renames test_models_tf.py into test_models_zoo_tf.py
  • adds unittest for PyTorch OCR zoo

Any feedback is welcome!

@fg-mindee fg-mindee added ext: tests Related to tests folder framework: pytorch Related to PyTorch backend labels Sep 29, 2021
@fg-mindee fg-mindee added this to the 0.4.1 milestone Sep 29, 2021
@fg-mindee fg-mindee self-assigned this Sep 29, 2021
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #499 (110b8c5) into main (6517000) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
+ Coverage   94.97%   95.14%   +0.16%     
==========================================
  Files         108      108              
  Lines        4181     4181              
==========================================
+ Hits         3971     3978       +7     
+ Misses        210      203       -7     
Flag Coverage Δ
unittests 95.14% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/builder.py 93.00% <0.00%> (-1.00%) ⬇️
...dels/detection/differentiable_binarization/base.py 91.97% <0.00%> (+0.61%) ⬆️
...s/detection/differentiable_binarization/pytorch.py 98.29% <0.00%> (+0.85%) ⬆️
doctr/models/recognition/crnn/pytorch.py 100.00% <0.00%> (+1.09%) ⬆️
doctr/models/predictor/pytorch.py 51.28% <0.00%> (+12.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6517000...110b8c5. Read the comment docs.

@fg-mindee fg-mindee merged commit 3b2d375 into main Sep 29, 2021
@fg-mindee fg-mindee deleted the test-pt-zoo branch September 29, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder framework: pytorch Related to PyTorch backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants