-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Split DocArtefacts into subsets and updated its class mapping #601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Should we add the collate function here?
- Also, we need to obtain absolute box coordinates. Right now we use relative ones.
Oh yeah, you're right, I'll change this
But that's OK, most of our datasets are in relative coords, and we convert it if not. |
For the collate function, actually I just checked and it's already working @SiddhantBahuguna : from doctr.datasets import DocArtefacts
from doctr.datasets import DataLoader
ds = DocArtefacts(train=True, download=True)
train_loader = DataLoader(ds, batch_size=2)
train_iter = iter(train_loader)
x, targets = next(train_iter) And the results look satisfactory to me: # Check shape of input
print(x.shape)
print(len(targets))
print(targets[0])
|
Codecov Report
@@ Coverage Diff @@
## main #601 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 110 110
Lines 4265 4269 +4
=======================================
+ Hits 4097 4101 +4
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output is following our expectations. Collate problem is resolved now. Thanks:)
This PR introduces the following modifications:
numpy.array
of class indicesAny feedback is welcome!