-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fixed docstrings of datasets #603
Conversation
Codecov Report
@@ Coverage Diff @@
## main #603 +/- ##
==========================================
+ Coverage 96.03% 96.06% +0.02%
==========================================
Files 110 110
Lines 4265 4265
==========================================
+ Hits 4096 4097 +1
+ Misses 169 168 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the docstring fix!
@@ -30,6 +30,7 @@ class DetectionDataset(AbstractDataset): | |||
sample_transforms: composable transformations that will be applied to each image | |||
rotated_bbox: whether polygons should be considered as rotated bounding box (instead of straight ones) | |||
""" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious here, why was this needed? (all style checks are passing)
>>> img, target = train_set[0] | ||
|
||
Args: | ||
img_folder: path to the images folder | ||
labels_path: pathe to the json file containing all labels (character sequences) | ||
sample_transforms: composable transformations that will be applied to each image | ||
""" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
adding blank line between docstring and constructor (format)
and fix two wrong docstrings / docu