-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SynthWordGenerator to text reco training scripts #825
Conversation
Codecov Report
@@ Coverage Diff @@
## main #825 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 131 131
Lines 4988 4988
=======================================
Hits 4787 4787
Misses 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Felix!
Would you mind just making this PR about fixing the german vocab please?
And about your suggestion to replace the character by a double S, I think it's a dangerous idea because a vocab element = a theoretical character = a computer character so far. With this, we'd be breaking this rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! For now, it would be good to have a similar transformation set as other recognition tasks (cf. my comments). Let me know what you think 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the edits! Still a few things to address and we'll be good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Felix!
Final adjustments to make (my comments also apply to the tensorflow script) :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Felix 🙏
After some feedback now this PR integrates only the WordGenerator into the training scripts 😄
Any feedback is welcome 😃