-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update bug report ticket with Active backend field #853
Conversation
Codecov Report
@@ Coverage Diff @@
## main #853 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 133 133
Lines 5197 5200 +3
=======================================
+ Hits 4929 4932 +3
Misses 268 268
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hi @felixdittrich92 :) Thanks for the PR! I'm having mixed feelings about this feature:
What do you think? |
@fg-mindee |
Considering that the env collection script may be run in another window with different env var, I think it's not useful to display it there. The script shows whether TF or PyTorch can be used, which usually gives us all the necessary information.
That might be a good idea actually, to log the enabled backend. For now, without any env var set, file_utils with return True for both PyTorch and TF if both libraries are installed. The priority is only given in Perhaps the best option would be to edit the bug report template? (ask user to specify which backend they are running, and how to check that) |
ftm i agree that this would be the easiest way i have totally forgot this templates 😅 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Only a few things left to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Felix!!
As discussed:
updates the bug report ticket that we can check which backend is enabled for the code the user is running