-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Fixed mypy and moved tool configs to pyproject.toml #966
Conversation
Codecov Report
@@ Coverage Diff @@
## main #966 +/- ##
=======================================
Coverage 94.89% 94.89%
=======================================
Files 134 134
Lines 5540 5542 +2
=======================================
+ Hits 5257 5259 +2
Misses 283 283
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@frgfm thanks a lot that's really helpful :) some mypy issues left |
@frgfm I have canceled the jobs (runs since ~2hrs to find matching packages for tf): https://github.com/mindee/doctr/runs/7091359034?check_suite_focus=true #dependency war |
@frgfm again :/ |
All good now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot really nice 👍
Only one question what about flake (looks like it was not triggered) ? :)
It has been, but I changed the python runtime and renamed the job, so we have to update the "required" jobs :) |
Yeah i see and was currently on track to check this 😅 |
@frgfm can we finish this ? :) |
As part of #957, this PR introduces the following modifications:
Any feedback is welcome!