Add homoglyphs rule types #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrozek
reviewed
Feb 23, 2024
Added in the description now, thanks for noting that! |
JAORMX
requested changes
Feb 26, 2024
| guidance: > | ||
| For every pull request submitted to a repository, this rule will check if the | ||
| pull request adds a new dependency with invisible characters. If it does, the rule will | ||
| fail and the pull request will be commented on. |
There was a problem hiding this comment.
The guidance is meant to tell you what to do if the rule fails. This is more appropriate for a description.
| guidance: > | ||
| For every pull request submitted to a repository, this rule will check if the | ||
| pull request adds text with mixed scripts. If it does, the rule will | ||
| fail and the pull request will be commented on. |
There was a problem hiding this comment.
The guidance is meant to tell you what to do if the rule fails. This is more appropriate for a description.
There was a problem hiding this comment.
Thanks: updated
Merged
JAORMX
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implications of homoglyphs type of attacks are described in mindersec/minder#2121
It also contains additional explicatory links and useful examples.