Revert "Address feedback and remove provider checks from CLI"

This reverts commit acdbdaa.

cmd/cli/app/artifact/artifact_get.go

@@ -17,12 +17,14 @@ package artifact
 
 import (
 	"context"
+	"fmt"
 	"os"
 
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 	"google.golang.org/grpc"
 
+	"github.com/stacklok/minder/cmd/cli/app"
 	"github.com/stacklok/minder/internal/util"
 	"github.com/stacklok/minder/internal/util/cli"
 	minderv1 "github.com/stacklok/minder/pkg/api/protobuf/go/minder/v1"
@@ -45,6 +47,11 @@ func getCommand(ctx context.Context, cmd *cobra.Command, conn *grpc.ClientConn)
 	artifactID := viper.GetString("id")
 	latestVersions := viper.GetInt32("versions")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	// check artifact by name
 	art, err := client.GetArtifactById(ctx, &minderv1.GetArtifactByIdRequest{
 		Context:        &minderv1.Context{Provider: &provider, Project: &project},

cmd/cli/app/profile/apply.go

@@ -26,6 +26,7 @@ import (
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/status"
 
+	"github.com/stacklok/minder/cmd/cli/app"
 	"github.com/stacklok/minder/internal/util/cli"
 	minderv1 "github.com/stacklok/minder/pkg/api/protobuf/go/minder/v1"
 )
@@ -46,6 +47,11 @@ func applyCommand(_ context.Context, cmd *cobra.Command, conn *grpc.ClientConn)
 	project := viper.GetString("project")
 	f := viper.GetString("file")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	table := NewProfileTable()
 
 	applyFunc := func(ctx context.Context, f string, p *minderv1.Profile) (*minderv1.Profile, error) {

cmd/cli/app/profile/create.go

@@ -24,6 +24,7 @@ import (
 	"github.com/spf13/viper"
 	"google.golang.org/grpc"
 
+	"github.com/stacklok/minder/cmd/cli/app"
 	"github.com/stacklok/minder/internal/util/cli"
 	minderv1 "github.com/stacklok/minder/pkg/api/protobuf/go/minder/v1"
 )
@@ -44,6 +45,11 @@ func createCommand(_ context.Context, cmd *cobra.Command, conn *grpc.ClientConn)
 	project := viper.GetString("project")
 	f := viper.GetString("file")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	table := NewProfileTable()
 
 	createFunc := func(ctx context.Context, f string, p *minderv1.Profile) (*minderv1.Profile, error) {

cmd/cli/app/profile/delete.go

@@ -17,12 +17,14 @@ package profile
 
 import (
 	"context"
+	"fmt"
 	"os"
 
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 	"google.golang.org/grpc"
 
+	"github.com/stacklok/minder/cmd/cli/app"
 	"github.com/stacklok/minder/internal/util/cli"
 	minderv1 "github.com/stacklok/minder/pkg/api/protobuf/go/minder/v1"
 )
@@ -42,6 +44,11 @@ func deleteCommand(ctx context.Context, cmd *cobra.Command, conn *grpc.ClientCon
 	project := viper.GetString("project")
 	id := viper.GetString("id")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	// Delete profile
 	_, err := client.DeleteProfile(ctx, &minderv1.DeleteProfileRequest{
 		Context: &minderv1.Context{Provider: &provider, Project: &project},

cmd/cli/app/profile/get.go

@@ -47,6 +47,11 @@ func getCommand(ctx context.Context, cmd *cobra.Command, conn *grpc.ClientConn)
 	format := viper.GetString("output")
 	id := viper.GetString("id")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	// Ensure the output format is supported
 	if !app.IsOutputFormatSupported(format) {
 		return cli.MessageAndError(fmt.Sprintf("Output format %s not supported", format), fmt.Errorf("invalid argument"))

cmd/cli/app/profile/list.go

@@ -45,6 +45,11 @@ func listCommand(ctx context.Context, cmd *cobra.Command, conn *grpc.ClientConn)
 	project := viper.GetString("project")
 	format := viper.GetString("output")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	// Ensure the output format is supported
 	if !app.IsOutputFormatSupported(format) {
 		return cli.MessageAndError(fmt.Sprintf("Output format %s not supported", format), fmt.Errorf("invalid argument"))

cmd/cli/app/profile/status/status_get.go

@@ -50,6 +50,11 @@ func getCommand(ctx context.Context, cmd *cobra.Command, conn *grpc.ClientConn)
 	entityType := viper.GetString("entity-type")
 	format := viper.GetString("output")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	// Ensure the output format is supported
 	if !app.IsOutputFormatSupported(format) {
 		return cli.MessageAndError(fmt.Sprintf("Output format %s not supported", format), fmt.Errorf("invalid argument"))

cmd/cli/app/profile/status/status_list.go

@@ -48,6 +48,11 @@ func listCommand(ctx context.Context, cmd *cobra.Command, conn *grpc.ClientConn)
 	all := viper.GetBool("detailed")
 	rule := viper.GetString("rule")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	// Ensure the output format is supported
 	if !app.IsOutputFormatSupported(format) {
 		return cli.MessageAndError(fmt.Sprintf("Output format %s not supported", format), fmt.Errorf("invalid argument"))

cmd/cli/app/provider/provider_enroll.go

@@ -35,6 +35,7 @@ import (
 	"google.golang.org/grpc"
 	"google.golang.org/protobuf/types/known/timestamppb"
 
+	"github.com/stacklok/minder/cmd/cli/app"
 	"github.com/stacklok/minder/internal/util/cli"
 	"github.com/stacklok/minder/internal/util/rand"
 	minderv1 "github.com/stacklok/minder/pkg/api/protobuf/go/minder/v1"
@@ -67,6 +68,11 @@ func EnrollProviderCommand(ctx context.Context, cmd *cobra.Command, conn *grpc.C
 	owner := viper.GetString("owner")
 	yesFlag := viper.GetBool("yes")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	// Ask for confirmation if an owner is set on purpose
 	ownerPromptStr := "your personal account"
 	if owner != "" {

cmd/cli/app/quickstart/quickstart.go

@@ -141,6 +141,11 @@ func quickstartCommand(_ context.Context, cmd *cobra.Command, conn *grpc.ClientC
 	project := viper.GetString("project")
 	provider := viper.GetString("provider")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	// Confirm user wants to go through the quickstart process
 	yes := cli.PrintYesNoPrompt(cmd,
 		stepPromptMsgWelcome,

cmd/cli/app/repo/repo_delete.go

@@ -17,11 +17,13 @@ package repo
 
 import (
 	"context"
+	"fmt"
 
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 	"google.golang.org/grpc"
 
+	"github.com/stacklok/minder/cmd/cli/app"
 	"github.com/stacklok/minder/internal/util/cli"
 	minderv1 "github.com/stacklok/minder/pkg/api/protobuf/go/minder/v1"
 )
@@ -42,6 +44,11 @@ func deleteCommand(ctx context.Context, cmd *cobra.Command, conn *grpc.ClientCon
 	repoID := viper.GetString("id")
 	name := viper.GetString("name")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	// delete repo by id
 	if repoID != "" {
 		resp, err := client.DeleteRepositoryById(ctx, &minderv1.DeleteRepositoryByIdRequest{

cmd/cli/app/repo/repo_get.go

@@ -47,6 +47,11 @@ func getCommand(ctx context.Context, cmd *cobra.Command, conn *grpc.ClientConn)
 	repoid := viper.GetString("id")
 	name := viper.GetString("name")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	// Ensure the output format is supported
 	if !app.IsOutputFormatSupported(format) || format == app.Table {
 		return cli.MessageAndError(fmt.Sprintf("Output format %s not supported", format), fmt.Errorf("invalid argument"))

cmd/cli/app/repo/repo_list.go

@@ -46,6 +46,11 @@ func listCommand(ctx context.Context, cmd *cobra.Command, conn *grpc.ClientConn)
 	project := viper.GetString("project")
 	format := viper.GetString("output")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	// Ensure the output format is supported
 	if !app.IsOutputFormatSupported(format) {
 		return cli.MessageAndError(fmt.Sprintf("Output format %s not supported", format), fmt.Errorf("invalid argument"))

cmd/cli/app/repo/repo_register.go

@@ -33,6 +33,7 @@ import (
 	"github.com/spf13/viper"
 	"google.golang.org/grpc"
 
+	"github.com/stacklok/minder/cmd/cli/app"
 	"github.com/stacklok/minder/internal/util/cli"
 	"github.com/stacklok/minder/internal/util/cli/table"
 	minderv1 "github.com/stacklok/minder/pkg/api/protobuf/go/minder/v1"
@@ -63,6 +64,11 @@ func RegisterCmd(ctx context.Context, cmd *cobra.Command, conn *grpc.ClientConn)
 	project := viper.GetString("project")
 	repoList := viper.GetString("name")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return nil, fmt.Sprintf("provider %s is not supported yet", provider), fmt.Errorf("invalid argument")
+	}
+
 	// Get the list of repos
 	listResp, err := client.ListRepositories(ctx, &minderv1.ListRepositoriesRequest{
 		Context: &minderv1.Context{Provider: &provider, Project: &project},

cmd/cli/app/root.go

@@ -23,6 +23,7 @@ import (
 	"github.com/spf13/viper"
 
 	"github.com/stacklok/minder/internal/constants"
+	ghclient "github.com/stacklok/minder/internal/providers/github"
 	"github.com/stacklok/minder/internal/util/cli"
 )
 
@@ -125,3 +126,18 @@ func IsOutputFormatSupported(output string) bool {
 func SupportedOutputFormats() []string {
 	return []string{JSON, YAML, Table}
 }
+
+// IsProviderSupported returns true if the provider is supported
+func IsProviderSupported(provider string) bool {
+	for _, p := range SupportedProviders() {
+		if provider == p {
+			return true
+		}
+	}
+	return false
+}
+
+// SupportedProviders returns the supported providers list
+func SupportedProviders() []string {
+	return []string{ghclient.Github}
+}

cmd/cli/app/ruletype/ruletype_apply.go

@@ -26,6 +26,7 @@ import (
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/status"
 
+	"github.com/stacklok/minder/cmd/cli/app"
 	"github.com/stacklok/minder/internal/util"
 	"github.com/stacklok/minder/internal/util/cli"
 	minderv1 "github.com/stacklok/minder/pkg/api/protobuf/go/minder/v1"
@@ -45,6 +46,11 @@ func applyCommand(_ context.Context, cmd *cobra.Command, conn *grpc.ClientConn)
 	provider := viper.GetString("provider")
 	project := viper.GetString("project")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	fileFlag, err := cmd.Flags().GetStringArray("file")
 	if err != nil {
 		return cli.MessageAndError("Error parsing file flag", err)

cmd/cli/app/ruletype/ruletype_create.go

@@ -24,6 +24,7 @@ import (
 	"github.com/spf13/viper"
 	"google.golang.org/grpc"
 
+	"github.com/stacklok/minder/cmd/cli/app"
 	"github.com/stacklok/minder/internal/util"
 	"github.com/stacklok/minder/internal/util/cli"
 	minderv1 "github.com/stacklok/minder/pkg/api/protobuf/go/minder/v1"
@@ -44,6 +45,11 @@ func createCommand(_ context.Context, cmd *cobra.Command, conn *grpc.ClientConn)
 	provider := viper.GetString("provider")
 	project := viper.GetString("project")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	fileFlag, err := cmd.Flags().GetStringArray("file")
 	if err != nil {
 		return cli.MessageAndError("Error parsing file flag", err)

cmd/cli/app/ruletype/ruletype_delete.go

@@ -17,11 +17,13 @@ package ruletype
 
 import (
 	"context"
+	"fmt"
 
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 	"google.golang.org/grpc"
 
+	"github.com/stacklok/minder/cmd/cli/app"
 	"github.com/stacklok/minder/internal/util/cli"
 	minderv1 "github.com/stacklok/minder/pkg/api/protobuf/go/minder/v1"
 )
@@ -43,6 +45,11 @@ func deleteCommand(ctx context.Context, cmd *cobra.Command, conn *grpc.ClientCon
 	deleteAll := viper.GetBool("all")
 	yesFlag := viper.GetBool("yes")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	if deleteAll && !yesFlag {
 		// Ask for confirmation if deleteAll is set on purpose
 		yes := cli.PrintYesNoPrompt(cmd,

cmd/cli/app/ruletype/ruletype_get.go

@@ -47,6 +47,11 @@ func getCommand(ctx context.Context, cmd *cobra.Command, conn *grpc.ClientConn)
 	format := viper.GetString("output")
 	id := viper.GetString("id")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	// Ensure the output format is supported
 	if !app.IsOutputFormatSupported(format) {
 		return cli.MessageAndError(fmt.Sprintf("Output format %s not supported", format), fmt.Errorf("invalid argument"))

cmd/cli/app/ruletype/ruletype_list.go

@@ -45,6 +45,11 @@ func listCommand(ctx context.Context, cmd *cobra.Command, conn *grpc.ClientConn)
 	project := viper.GetString("project")
 	format := viper.GetString("output")
 
+	// Ensure provider is supported
+	if !app.IsProviderSupported(provider) {
+		return cli.MessageAndError(fmt.Sprintf("Provider %s is not supported yet", provider), fmt.Errorf("invalid argument"))
+	}
+
 	// Ensure the output format is supported
 	if !app.IsOutputFormatSupported(format) {
 		return cli.MessageAndError(fmt.Sprintf("Output format %s not supported", format), fmt.Errorf("invalid argument"))