-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minder CLI improvements - table interface, refactor use of flags, context, etc. #1919
Conversation
2a0b6d7
to
dbb5202
Compare
814fc18
to
486c863
Compare
1c4753a
to
0e27c21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good, the only thing I don't agree with is the app.IsProviderSupported
function, which I think should be removed as it'll prevent us from adding other providers in the future. Let's not add code we have to remove later for little benefit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying this locally, the tables look good! the only one that looks a little off is the whoami
list which looks a bit too slim. Is there a way for us to enforce minimal width?
+---------------+--------------------------------------+
| KEY | VALUE |
+---------------+--------------------------------------+
| Minder Server | api.stacklok.com:443 |
+---------------+--------------------------------------+
| Project | jaormx / |
| | xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx |
+---------------+--------------------------------------+
…equests, etc. Signed-off-by: Radoslav Dimitrov <[email protected]>
Signed-off-by: Radoslav Dimitrov <[email protected]>
Signed-off-by: Radoslav Dimitrov <[email protected]>
Signed-off-by: Radoslav Dimitrov <[email protected]>
Signed-off-by: Radoslav Dimitrov <[email protected]>
Signed-off-by: Radoslav Dimitrov <[email protected]>
Signed-off-by: Radoslav Dimitrov <[email protected]>
This reverts commit acdbdaa.
Signed-off-by: Radoslav Dimitrov <[email protected]>
9718c41
to
40f0230
Compare
@rdimitrov what changed? |
Signed-off-by: Radoslav Dimitrov <[email protected]>
Signed-off-by: Radoslav Dimitrov <[email protected]>
@JAORMX - Jakub merged his PR so I had to rebase. Also there was a diff in the make gen output. |
Signed-off-by: Radoslav Dimitrov <[email protected]>
Added a minimum width for tables of type key/value 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still looks a little too slim but we can fix that later
The following PR:
--repo
toname
when doing repo register for consistency with the rest of the repo commandsWhat's left:
Fixes: #1758
Fixes: #1754
Fixes: #1751
Fixes: #1749
Fixes: #1748