Pass through error messages from AuthFromMD for debugging #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGMETEOR
approved these changes
Dec 18, 2023
JAORMX
previously approved these changes
Dec 19, 2023
|
Oh, fails the linter |
evankanderson
force-pushed
the
auth-diagnosis-messages
branch
from
20345b6 to
817514b
Compare
JAORMX
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1957 -- requests though the GRPC gateway don't seem to have proper auth (returning
codes.Unauthenticated, but we're not providing anything more useful in terms of error message to distinguish different cases.I'd really love it if I'd written tests for
UnaryAuthorizationInterceptorearlier, but I compounded the technical debt here to get the quick fix in.