entity event handler test fixes #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is that the eventer should be ready to issue events before we try to parse and process an event. This also adds another log line to know if the test is blocked because of the last `Wait` call. Closes #1710
JAORMX
force-pushed
the
executor-test-fixes
branch
from
529eca2 to
162b43b
Compare
JAORMX
changed the title
rdimitrov
reviewed
Dec 22, 2023
rdimitrov
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that the eventer should be ready to issue events before we
try to parse and process an event.
This also adds another log line to know if the test is blocked because of the
last
Waitcall.Moreso, this adds logging to the mock event handler plugin.
Finally, this makes sure handler registration happens before the eventer runs, so we don't loose events.
Closes #1710