Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag for identity server base URL #2033

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Add flag for identity server base URL #2033

merged 1 commit into from
Dec 22, 2023

Conversation

eleftherias
Copy link
Contributor

Fix #1665

@eleftherias eleftherias requested a review from a team as a code owner December 22, 2023 13:15
JAORMX
JAORMX reviewed Dec 22, 2023
View reviewed changes
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm... don't we only need this for the auth commands?

@eleftherias
Copy link
Contributor Author

@JAORMX This is on the server side. It's used mainly for fetching the JWKS for validating the incoming token. It's also used for user deletion.

@JAORMX
Copy link
Contributor

JAORMX commented Dec 22, 2023

Oops, got confused. Shipit 🚢

@eleftherias eleftherias merged commit 71eb295 into mindersec:main Dec 22, 2023
17 checks passed
@eleftherias eleftherias deleted the 1665-idp-flag branch December 22, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAORMX JAORMX JAORMX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add config flag for identity issuer URL
2 participants
@eleftherias @JAORMX