Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to offline Sigstore verification and set TimestampVerificationData to nil #2131

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

rdimitrov
Copy link
Member

The following PR has the following changes:

Thanks to @haydentherapper for raising this! 🍻

@rdimitrov rdimitrov requested a review from a team as a code owner January 17, 2024 01:58
@rdimitrov rdimitrov self-assigned this Jan 17, 2024
Copy link

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formally rubber-stamping since both @haydentherapper approved this PR earlier but also @rdimitrov asked his original PR earlier.

@rdimitrov rdimitrov merged commit 0c0afc6 into mindersec:main Jan 17, 2024
17 checks passed
@rdimitrov rdimitrov deleted the sigstore branch January 17, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants