Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proto files for pagination #2138

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

eleftherias
Copy link
Contributor

Related to PR #2097

Ref #520

@eleftherias eleftherias requested a review from a team as a code owner January 17, 2024 12:53
@eleftherias eleftherias merged commit 0056320 into mindersec:main Jan 17, 2024
17 checks passed
@eleftherias eleftherias deleted the offset-protos branch January 17, 2024 13:10
@Vyom-Yadav
Copy link
Member

@eleftherias Just a question: the last commit from main on my local branch was e370b08, and make gen is clean, i.e. not updating any files. So, I'm assuming this is version-related.

Local dependency should stick to protoc-gen-go v1.31.0 right?

eleftherias added a commit to eleftherias/minder that referenced this pull request Jan 17, 2024
@eleftherias
Copy link
Contributor Author

@Vyom-Yadav sorry about the confusion. Your PR was correct, as you mentioned it was a version-related problem because I was using an older version of the tool. I've submitted a new PR to revert my changes #2141.

eleftherias added a commit that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants