Actually run authz tests #2165
Merged
Actually run authz tests #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
force-pushed
the
authz-tests
branch
3 times, most recently
from
7dc4289 to
b5ea2e5
Compare
The authz tests we had were actually not issuing an error because the `fga` command outputted the "Usage" and failed silently. It turned out not to be trivial to run the command from our tests, so I ended up adding the `fga` CLI installation to the bootstrap target, adding a Makefile target and creating a CI job out of it. The `authz` directory was moved into `internal/authz/model` in as a cleanup. But also, we'll eventually embed the model in the go server as part of the migration.
eleftherias
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authz tests we had were actually not issuing an error because the
fgacommand outputted the "Usage" and failed silently. It turned outnot to be trivial to run the command from our tests, so I ended up
adding the
fgaCLI installation to the bootstrap target, adding aMakefile target and creating a CI job out of it.
The
authzdirectory was moved intointernal/authz/modelin as acleanup. But also, we'll eventually embed the model in the go server as
part of the migration.