Support GitHub attestation endpoint #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think your |
JAORMX
reviewed
Jan 25, 2024
So we started filing the issues in the epics repo because it's private and we were not sure if we can reference the work publicly as the GH attestations program is not public. We got a green light from GH yesterday to merge the code in a public repo, but for some reason I can't seem to be able to move the issue to the minder repo. For now, I'm going to reference the full URL of the issue in the epics repo. Is there a way to move the issue or do you know what can be preventing the issue from being moved? Is it that the epics repo is private but the minder repo is public? |
Instead of hardcoding a single token-based authentication, let's pass a slice of authMethods the called wants to be used. The verifier will pick an available verification method based on the authentication method provided by the caller. Related: stacklok/epics#174
In addition to fetching provenance attestations from an OCI image, let's also support the GitHub attestation endpoint as a fallback (a fallback since it's not GA yet). The attestation reply is unmarshalled into a protobuf representation and passed to sigstore-go. Fixes: stacklok/epics#174
jhrozek
force-pushed
the
gh_attestation
branch
from
cd6555b to
6b6f87b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to fetching provenance attestations from an OCI image, let's also
support the GitHub attestation endpoint as a fallback (a fallback since it's
not GA yet).
The attestation reply is unmarshalled into a protobuf representation and
passed to sigstore-go.
Fixes: https://github.com/stacklok/epics/issues/174